COMP: a fix for system double-conversion build#366
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 9, 2019
Merged
COMP: a fix for system double-conversion build#366dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Member
|
CI not happy 🌧️ |
Member
Author
|
I forgot to account for usage of internal double-conversion 😬 I will fix it later. |
FAILED: Modules/Core/Common/src/CMakeFiles/ITKCommon.dir/itkNumberToString.cxx.obj C:\PROGRA~2\MICROS~1\2017\BUILDT~1\VC\Tools\MSVC\1415~1.267\bin\Hostx64\x64\cl.exe /TP -DITKCommon_EXPORTS -D_CRT_FAR_MAPPINGS_NO_DEPRECATE -D_CRT_IS_WCTYPE_NO_DEPRECATE -D_CRT_MANAGED_FP_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE_GLOBALS -D_CRT_SETERRORMODE_BEEP_SLEEP_NO_DEPRECATE -D_CRT_TIME_FUNCTIONS_NO_DEPRECATE -D_CRT_VCCLRIT_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -IC:\src\vcpkg\installed\x64-windows\include\double-conversion -IModules\ThirdParty\KWIML\src -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\KWIML\src -IModules\ThirdParty\KWSys\src -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNL\src\vxl\v3p\netlib -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNL\src\vxl\vcl -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNL\src\vxl\core -IModules\ThirdParty\VNL\src\vxl\v3p\netlib -IModules\ThirdParty\VNL\src\vxl\vcl -IModules\ThirdParty\VNL\src\vxl\core -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNLInstantiation\include -IModules\Core\Common -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\Core\Common\include -IModules\ThirdParty\KWSys\src\KWSys -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNL\src\vxl\core\vnl\algo -IC:\src\vcpkg\buildtrees\itk\ITK\Modules\ThirdParty\VNL\src\vxl\core\vnl /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP -W3 /bigobj /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /FoModules\Core\Common\src\CMakeFiles\ITKCommon.dir\itkNumberToString.cxx.obj /FdModules\Core\Common\src\CMakeFiles\ITKCommon.dir\ /FS -c C:\src\vcpkg\buildtrees\itk\ITK\Modules\Core\Common\src\itkNumberToString.cxx Microsoft (R) C/C++ Optimizing Compiler Version 19.15.26729 for x64 Copyright (C) Microsoft Corporation. All rights reserved. C:\src\vcpkg\installed\x64-windows\include\double-conversion\double-conversion.h(31): fatal error C1083: Cannot open include file: 'double-conversion/utils.h': No such file or directory
89cbf76 to
3527a92
Compare
thewtex
approved these changes
Jan 5, 2019
hjmjohnson
approved these changes
Jan 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix microsoft/vcpkg#4334.